Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): Support show dictionaries DQL. #16602

Merged
merged 18 commits into from
Oct 15, 2024

Conversation

Winnie-Hong0927
Copy link
Contributor

@Winnie-Hong0927 Winnie-Hong0927 commented Oct 12, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

We continue to improve the logical plan and binder of dictionary.
This allows us to execute Show-Dictionaries DQL statements in MySql.
For example:

  1. Show all dictionaries in MySql: show dictionaries;
  2. Show dictionaries in specific database: show dictionaries from | in db_name;
  3. Show dictionaries with conditions: show dictionaries like 'd%'

fix: #16551

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 12, 2024
@b41sh b41sh self-requested a review October 12, 2024 14:28
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution. @Winnie-Hong0927

@b41sh b41sh added this pull request to the merge queue Oct 15, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 15, 2024
@BohuTANG BohuTANG merged commit 86cd608 into databendlabs:main Oct 15, 2024
72 checks passed
@BohuTANG
Copy link
Member

@soyeric128 New feature is up, please help with the documentation, thanks!

@BohuTANG
Copy link
Member

@Winnie-Hong0927 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support show dictionaries
3 participants