Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iceberg): Make sure iceberg table has been loaded #16593

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Oct 10, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Make sure iceberg able to load via REST catalog.

This PR fixes an issue that prevents iceberg table been constructed correctly. After this PR, iceberg table is able to read successfully:

image

I will add full tpch test upon iceberg later.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 10, 2024
@databendlabs databendlabs deleted a comment from github-actions bot Oct 10, 2024
@databendlabs databendlabs deleted a comment from github-actions bot Oct 10, 2024
@Xuanwo Xuanwo added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 1be1360 Oct 11, 2024
74 checks passed
@Xuanwo Xuanwo deleted the fix-iceberg-table-load branch October 11, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants