refactor: simplify get_tables_history() #16572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this method return `TableNIV` instead of `TableInfo`. TableInfo includes information that `SchemaApi` can not provide.
github-actions
bot
added
the
pr-refactor
SkyFan2002
approved these changes
Oct 9, 2024
TCeason
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
LGTM. And better to use TableNiv refactor get_table_meta_history ? https://github.com/databendlabs/databend/blob/main/src/meta/api/src/schema_api.rs#L206
Yes |
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: simplify get_tables_history()
Make this method return
TableNIVinstead ofTableInfo. TableInfoincludes information that
SchemaApican not provide.Tests
Type of change
Related Issues
This change is