Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): add more asserts #16536

Merged
merged 4 commits into from
Sep 28, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 27, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): add more asserts

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 27, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 28, 2024
Merged via the queue into databendlabs:main with commit c6bd10b Sep 28, 2024
71 checks passed
@sundy-li sundy-li deleted the more-asserts branch September 28, 2024 16:26
zhang2014 added a commit to zhang2014/datafuse that referenced this pull request Oct 8, 2024
zhang2014 added a commit to zhang2014/datafuse that referenced this pull request Oct 10, 2024
BohuTANG pushed a commit that referenced this pull request Oct 10, 2024
…6566)

* fix(query): fix cannot obtain stack trace when segmentation fault

* fix(query): fix cannot obtain stack trace when segmentation fault

* Revert "chore(query): add more asserts (#16536)"

This reverts commit c6bd10b.

* fix(query): forward the stack to another thread for symbol parsing

* fix(query): forward the stack to another thread for symbol parsing

* fix(query): forward the stack to another thread for symbol parsing

* fix(query): comment --compress-debug-sections=zlib

* fix(query): comment --compress-debug-sections=zlib

* fix(query): comment --compress-debug-sections=zlib

* Revert "Revert "chore(query): add more asserts (#16536)""

This reverts commit e7ce5fe.

* fix(query): fix cannot obtain stack trace when segmentation fault
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants