Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-default catalog should not call get_table_function #16410

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Sep 6, 2024

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Non-default catalog doesn't have table functions, we should avoid calling them.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 6, 2024
@Xuanwo Xuanwo requested a review from sundy-li September 6, 2024 08:12
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Sep 6, 2024
@dosubot dosubot bot added A-query Area: databend query C-bug Category: something isn't working labels Sep 6, 2024
@Xuanwo Xuanwo requested a review from BohuTANG September 6, 2024 08:31
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2024
@Xuanwo Xuanwo added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@Xuanwo Xuanwo added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@BohuTANG BohuTANG merged commit db6a305 into databendlabs:main Sep 6, 2024
105 checks passed
@Xuanwo Xuanwo deleted the fix-table-function branch September 6, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-bug Category: something isn't working lgtm This PR has been approved by a maintainer pr-bugfix this PR patches a bug in codebase size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants