-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): Support access Redis data from dictionaries via the dict_get
function.
#16389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b41sh
changed the title
feat(query): Support access data from dictionaries via the
feat(query): Support access Redis from dictionaries via the Sep 6, 2024
dict_get
function.dict_get
function.
b41sh
changed the title
feat(query): Support access Redis from dictionaries via the
feat(query): Support access Redis data from dictionaries via the Sep 6, 2024
dict_get
function.dict_get
function.
b41sh
reviewed
Sep 7, 2024
tests/sqllogictests/suites/query/functions/02_0077_function_dict_get.test
Outdated
Show resolved
Hide resolved
sundy-li
reviewed
Sep 7, 2024
sundy-li
reviewed
Sep 7, 2024
src/query/service/src/pipelines/processors/transforms/transform_dictionary.rs
Outdated
Show resolved
Hide resolved
sundy-li
reviewed
Sep 7, 2024
tests/sqllogictests/suites/query/functions/02_0077_function_dict_get.test
Show resolved
Hide resolved
sundy-li
approved these changes
Sep 9, 2024
b41sh
approved these changes
Sep 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
…t_get` function. (#16389) * feat: dict_get to redis. * fix * fix: resolve_dict_get * fix * fix * fix * fix and fmt * feat: add transform_dict_get * feat: add lazy_static * feat: add key's type Number and prepare to update transform more. * update: bind_create_dictionary * update: transform default expr * fix: transform and binder and type_check * update: operator & cache. * fix * fix: operator * fix: transform--operators * update: transform&resolve&argument * fix * update: binder & test. * feat: redis-server & test. * fmt * update: test. * fix: binder & test. * fix: binder & test. * update: errorcode & test * fix * fix * fix * fix * update: binder. * fix * fix: schema & transform * merge * update:test * fix * fix * fix. * update: binder & transform. * fix: dict_get test * update. * update
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 9, 2024
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query
Area: databend query
C-feature
Category: feature
lgtm
This PR has been approved by a maintainer
pr-feature
this PR introduces a new feature to the codebase
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This pull request introduces support for accessing Redis data from dictionaries using the
dict_get
function. Other source like MySQL, PostgreSQL will be introduced in the future PRs.options are used to provide the Redis connection URL,
host
andport
are required options, andusername
,password
,db_index
are optional options.connect to Redis and set some test keys and values
dict_get
Function:This PR also introduces a
mock_source
, which simulates a Redis server to test thedict_get
function. Future work will expand this mock data source functionality to include support for other sources such as MySQL, PostgreSQL, and more.part of #15901
Tests
Type of change
This change is