chore: use logforth to replace fern #16249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-chore
everpcpc
approved these changes
Aug 19, 2024
|
There are extra error messages: Need fix the ci tests. |
dosubot
bot
added
size:XL
everpcpc
reviewed
Sep 19, 2024
| serde_json::to_string(&fields).unwrap_or_default(), | ||
| )); | ||
| } | ||
| Some(query_id) => { |
There was a problem hiding this comment.
query_id missing for the new system logging cc @andylokandy
|
This PR introduces a breaking change to the design. Cloud query history and system logs are all broken now. |
andylokandy
added a commit
to andylokandy/databend
that referenced
this pull request
Sep 19, 2024
BohuTANG
added a commit
that referenced
this pull request
Sep 19, 2024
* fix: revert log format breakage from #16249 * fix --------- Co-authored-by: Bohu <[email protected]>
11 tasks
11 tasks
dantengsky
pushed a commit
to dantengsky/fuse-query
that referenced
this pull request
Oct 28, 2024
11 tasks
dantengsky
added a commit
that referenced
this pull request
Oct 28, 2024
* fix: revert log format breakage from #16249 * fix --------- Co-authored-by: andylokandy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is