Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reduce memory copy during the compact process #15598

Closed
wants to merge 5 commits into from
Closed

feat: reduce memory copy during the compact process #15598

wants to merge 5 commits into from

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented May 21, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Instead of concatenating multiple DataBlocks into a single DataBlock, directly writing multiple DataBlocks into a single table block.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label May 21, 2024
@SkyFan2002 SkyFan2002 added the ci-cloud Build docker image for cloud test label May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15598-4a50e19

note: this image tag is only available for internal use,
please check the internal doc for more details.

@SkyFan2002
Copy link
Member Author

There is no significant performance improvement, but it has increased the code complexity. Close it

@SkyFan2002 SkyFan2002 closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: optimize table data compaction
1 participant
@SkyFan2002