Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions): add new function: map_pick #15573

Merged
merged 10 commits into from
Nov 5, 2024
Merged

feat(functions): add new function: map_pick #15573

merged 10 commits into from
Nov 5, 2024

Conversation

hanxuanliang
Copy link
Contributor

@hanxuanliang hanxuanliang commented May 18, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

part of #15295

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label May 18, 2024
@hanxuanliang
Copy link
Contributor Author

Currently, it has been implemented:

  • map_pick(map, [key...])

@b41sh b41sh self-requested a review May 18, 2024 12:35
@hanxuanliang hanxuanliang force-pushed the feat/15295_map_pick branch 2 times, most recently from 0f8276d to b3bff22 Compare May 23, 2024 01:18
b41sh
b41sh reviewed May 23, 2024
View reviewed changes
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
b41sh
b41sh reviewed May 27, 2024
View reviewed changes
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
src/query/functions/src/scalars/map.rs Outdated Show resolved Hide resolved
@b41sh
Copy link
Member

b41sh commented Jun 6, 2024

Hi @hanxuanliang It's been a long time since last update, have you made any progress recently?

@hanxuanliang
Copy link
Contributor Author

I'm sorry that the issue has been delayed recently due to personal matters. I will finish the following pr content at the weekend

@hanxuanliang
Copy link
Contributor Author

sorry. I will finish the following pr content in the weekend

@b41sh b41sh added this pull request to the merge queue Nov 5, 2024
Merged via the queue into databendlabs:main with commit 094f72d Nov 5, 2024
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b41sh b41sh b41sh approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanxuanliang @b41sh