Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): refactor truncate metrics #12634

Merged
merged 6 commits into from
Aug 31, 2023
Merged

chore(query): refactor truncate metrics #12634

merged 6 commits into from
Aug 31, 2023

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Aug 31, 2023 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

chore(query): refactor truncate metrics

  • Closes #issue

This change is Reviewable

@vercel
Copy link

vercel bot commented Aug 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
databend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 5:14am

@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Aug 31, 2023
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 31, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-12634-b4aa36b

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report

@zhang2014 zhang2014 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Aug 31, 2023
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-12634-a592d18

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG
Copy link
Member 

[SQL] select value from system.metrics where metric = 'fuse_deletion_block_range_pruned_nums';
[Diff] (-expected|+actual)
Error: SelfError("sqllogictest failed")
-   2.0
+   4.0

@github-actions
Copy link
Contributor

cloud cloud

ClickBench Report

@zhang2014 zhang2014 merged commit f1d47d8 into databendlabs:main Aug 31, 2023
54 checks passed
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
@zhang2014 @andylokandy
chore(query): refactor truncate metrics (databendlabs#12634)
070f94f 
* chore(query): refactor truncate metrics

* chore(query): refactor truncate metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaneur2020 flaneur2020 flaneur2020 approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhang2014 @BohuTANG @flaneur2020