Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable benchmark cache #12567

Closed
wants to merge 0 commits into from

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Aug 23, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  • Closes #issue

This change is Reviewable

@Dousir9 Dousir9 added the ci-benchmark Benchmark: run all test label Aug 23, 2023
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Aug 24, 2023 2:34am

@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-12567-61493ca

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhang2014
Copy link
Member

data cache may cause oom of the ci benchmark instance, may we should disable until it's production ready?

@BohuTANG
Copy link
Member

We should establish a stable benchmark environment that can measure our benchmarks for both releases and PRs. and avoid making frequent changes. If alterations are made, each release from the past can be regenerated if need.

@Dousir9 Dousir9 marked this pull request as ready for review August 24, 2023 01:26
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Aug 24, 2023
@Dousir9 Dousir9 requested a review from everpcpc August 24, 2023 01:34
@Dousir9 Dousir9 closed this Aug 24, 2023
@Dousir9 Dousir9 reopened this Aug 24, 2023
@Dousir9 Dousir9 removed the request for review from everpcpc August 24, 2023 02:25
@Dousir9 Dousir9 closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants