if error output push default

databendlabs · Nov 2, 2024 · 769e9f5 · 769e9f5
1 parent 658141d
commit 769e9f5
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/query/functions/src/scalars/datetime.rs b/src/query/functions/src/scalars/datetime.rs
@@ -156,10 +156,12 @@ fn register_convert_timezone(registry: &mut FunctionRegistry) {
                 let t_tz: Tz = match target_tz.parse() {
                     Ok(tz) => tz,
                     Err(e) => {
-                        return ctx.set_error(
+                        ctx.set_error(
                             output.len(),
                             format!("cannot parse target `timezone`. {}", e),
                         );
+                        output.push(0);
+                        return;
                     }
                 };
 
@@ -173,9 +175,15 @@ fn register_convert_timezone(registry: &mut FunctionRegistry) {
                 match offset_as_micros_sec.checked_mul(MICROS_PER_SEC) {
                     Some(offset) => match result_timestamp.checked_add(offset) {
                         Some(res) => output.push(res),
-                        None => ctx.set_error(output.len(), "calc final time error".to_string()),
+                        None => {
+                            ctx.set_error(output.len(), "calc final time error".to_string());
+                            output.push(0);
+                        }
                     },
-                    None => ctx.set_error(output.len(), "calc time offset error".to_string()),
+                    None => {
+                        ctx.set_error(output.len(), "calc time offset error".to_string());
+                        output.push(0);
+                    }
                 }
             },
         ),