-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config support parse tls #446
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @sundy-li |
TCeason
force-pushed
the
fix_440
branch
3 times, most recently
from
July 3, 2024 16:12
c2945de
to
fcfe0f6
Compare
everpcpc
reviewed
Jul 4, 2024
sundy-li
approved these changes
Jul 4, 2024
everpcpc
approved these changes
Jul 4, 2024
everpcpc
requested changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
connection.args
is designed to be equivalent to arguments in DSN, so it is a map<string, string>
, tls is not included.
Maybe it should be
[connection]
tls = true
[connection.args]
...
or
[connection]
...
[connection.args]
sslmode = "disable"
Good idea. Fixed. Please review the newest commit.
|
everpcpc
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
➜ ~/database/source-code/bendsql👆 git:(main) ⚡ ./target/debug/bendsql --tls=true
path is "/home/taichong/.config/bendsql/config.toml"
not set dsn : databend://root@localhost:8000?tls=false
Welcome to BendSQL 0.18.3-fbb976e(2024-07-03T13:28:17.492814078Z).
Connecting to localhost:8000 as user root.
Error: APIError: RequestError: error sending request for url (https://localhost:8000/v1/query)
And I think the doc in README.md is wrong. That is right.
➜ ~/database/source-code/bendsql👆 git:(main) ⚡ ./target/debug/bendsql
path is "/home/taichong/.config/bendsql/config.toml"
not set dsn : databend://root@localhost:8000?tls=true
Welcome to BendSQL 0.18.3-fbb976e(2024-07-03T13:28:17.492814078Z).
Connecting to localhost:8000 as user root.
Error: APIError: RequestError: error sending request for url (https://localhost:8000/v1/query)
Fix: #440