[PLUGIN-1803] Add validation for logical type (array/repeated) #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
force-pushed
the
patch/array-logical-type-validation
branch
from
9892d6d
to
14d3260
Compare
itsankit-google
requested changes
Aug 30, 2024
itsankit-google
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for logical type (array/repeated)
Jira : PLUGIN-1803
Description
When we have a BQ field with repeated logical type (say array of dates) current validation only works primitive types, and it fails when
BQ.type (=DATE)is compared with the primitive type(INT for Date)causing an invalid mismatch error.Code change
BigQueryUtil.javaUnit Tests
BigQueryUtilTest.java