[Cherrypicked] Redshift source and connector plugin added. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Redshift Source plugin for 6.9.x versions.
vikasrathee-cs
changed the title
| @@ -59,7 +59,7 @@ | |||
| public final class DBUtils { | |||
| private static final Logger LOG = LoggerFactory.getLogger(DBUtils.class); | |||
|
|
|||
| private static final Calendar PURE_GREGORIAN_CALENDAR = createPureGregorianCalender(); | |||
| public static final Calendar PURE_GREGORIAN_CALENDAR = createPureGregorianCalender(); | |||
There was a problem hiding this comment.
this was getting used in one of the class and was public in 1.11 release
There was a problem hiding this comment.
If it is not getting used in any of the redshift class related to your change, let's revert. Otherwise LGTM.
There was a problem hiding this comment.
It is getting used.
itsankit-google
approved these changes
Mar 21, 2024
vikasrathee-cs
merged commit cc334fe
into
data-integrations:release/1.10
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Redshift Source plugin for 6.9.x versions.
Cherrypicked from #485