Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace html2canvas with usingHtml2Image #1152

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

atalyaalon
Copy link
Contributor

@atalyaalon atalyaalon commented Oct 31, 2024

html-to-image didn't have the built in onclone In order to include removeMapControllers
Hence I used html-to-image for most images and html2canvas for map images

@atalyaalon atalyaalon added this to the v0.17.0 milestone Oct 31, 2024
@atalyaalon atalyaalon force-pushed the 1136-bug-axis-partial branch 2 times, most recently from dbc4848 to 02b20a6 Compare October 31, 2024 20:58
@atalyaalon
Copy link
Contributor Author

Solves #1136
@shaked-hayek FYI

@atalyaalon atalyaalon linked an issue Oct 31, 2024 that may be closed by this pull request
@atalyaalon atalyaalon merged commit 161594b into dev Oct 31, 2024
1 check passed
@atalyaalon atalyaalon deleted the 1136-bug-axis-partial branch October 31, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] axis is partial in img download
1 participant