Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

Make sure to populate the multidat error back up the stack #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okdistribute
Copy link

@okdistribute okdistribute commented Feb 12, 2017

I was getting a module mismatch error but it was hidden under the sheets. I think in general it's nice to propagate fatal errors like this up the stack

@yoshuawuyts
Copy link
Collaborator

The error is still being propagated; if you look at the stack trace it should be clear (:

Also: I wasn't aware module mismatch errors were handled through a callback; I would've assumed they threw? That seems like a rather odd use of callbacks imo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants