Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyword to allow disabling config forwarding in SSHCluster #8994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jan 27, 2025

Closes #8138

#8138 shows that in Windows there is a limit to environment variable size, and SSHCluster serialises your Dask config to forward to the remote processes. If your Dask config is really big then this will fail. There isn't a clear solution here, in #4465 we explored compressing config, but that isn't a perfect solution so hasn't been merged.

A reasonable workaround is to be able to just disable this functionality if you don't need it. Users in #8138 (comment) have reported just modifying distributed to disable this. This PR adds a kwarg to officially support disabling config forwarding.

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±0      27 suites  ±0   11h 40m 27s ⏱️ + 6m 21s
 4 116 tests ±0   4 002 ✅ +2    111 💤 ±0  3 ❌  - 1 
51 615 runs   - 1  49 315 ✅ +2  2 297 💤 +1  3 ❌  - 3 

For more details on these failures, see this check.

Results for commit 76d63b1. ± Comparison against base commit 49f5e74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSHCluster - localhost to localhost - The command line is too long
1 participant