Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SSLError in TCP comm #8983

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

jacobtomlinson
Copy link
Member

Closes #8936

It's been a couple of months since #8936 was opened and test_tls_comm_closed_implicit is still failing pretty consistently in CI with openssl==3.4.0.

It's still not clear whether this new SSLError that gets raised should be caught by Tornado, but I had a go at making the error handling more robust to SSLErrors.

This change assumes that SSLErrors that aren't UNKNOWN_CA are non-fatal.

  • Tests added / passed
  • Passes pre-commit run --all-files

@jacobtomlinson jacobtomlinson added the flaky test Intermittent failures on CI. label Jan 10, 2025
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    26 files   -     1      26 suites   - 1   11h 15m 8s ⏱️ - 15m 0s
 4 112 tests ±    0   4 000 ✅ +    2    111 💤 ± 0  1 ❌  - 2 
50 156 runs   - 1 407  47 914 ✅  - 1 356  2 241 💤  - 47  1 ❌  - 4 

For more details on these failures, see this check.

Results for commit c7c1ba0. ± Comparison against base commit c2ba834.

Copy link
Member

@fjetter fjetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Incredible that all of your test jobs are green

@fjetter fjetter merged commit bcdbabe into dask:main Jan 10, 2025
31 of 32 checks passed
@jacobtomlinson jacobtomlinson deleted the handle-ssl-error branch January 10, 2025 16:11
@jacobtomlinson
Copy link
Member Author

jacobtomlinson commented Jan 10, 2025

I did rerun a couple of unrelated failures, but yeah exciting that things are pretty much all green for once!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssl.SSLError: [SYS] unknown error (_ssl.c:2580) in test_tls_comm_closed_implicit
2 participants