Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8936
It's been a couple of months since #8936 was opened and
test_tls_comm_closed_implicit
is still failing pretty consistently in CI with openssl==3.4.0.It's still not clear whether this new SSLError that gets raised should be caught by Tornado, but I had a go at making the error handling more robust to SSLErrors.
This change assumes that SSLErrors that aren't
UNKNOWN_CA
are non-fatal.pre-commit run --all-files