Removed big-endian sparse tests #8982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on scipy/scipy#22258 (comment), this seemes to not be supported.
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 11h 29m 4s ⏱️ - 10m 54s For more details on these failures and errors, see this check. Results for commit 793567a. ± Comparison against base commit 26e84a9. This pull request removes 14 tests. |
jacobtomlinson
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
This seems fine to me. Thanks @TomAugspurger
The readthedocs failures are a bit weird, but they don't seem related to this PR.
TomAugspurger
added a commit
to TomAugspurger/distributed
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8977. Based on scipy/scipy#22258 (comment), it does look like removing these test cases is appropriate (apparently big-endian arrays weren't ever really supported?), so I've changed the skips to removals, and also removed from the cupy file.