Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove user argument from reloading ontology cache #3447

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

BalduinLandolt
Copy link
Contributor

@BalduinLandolt BalduinLandolt commented Dec 22, 2024

Pull Request Checklist

Task Description/Number

Remove unused parameter and obsolete checks. Reloading ontologies in ontology cache does not require a requesting user.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

@BalduinLandolt BalduinLandolt changed the title Remove user argument from reloading ontology cache refactor: Remove user argument from reloading ontology cache Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (6ebe8e7) to head (b70f381).
Report is 151 commits behind head on main.

Files with missing lines Patch % Lines
...api/slice/admin/api/service/StoreRestService.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3447      +/-   ##
==========================================
- Coverage   83.04%   82.55%   -0.50%     
==========================================
  Files         290      309      +19     
  Lines       23087    22791     -296     
==========================================
- Hits        19172    18814     -358     
- Misses       3915     3977      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BalduinLandolt BalduinLandolt marked this pull request as ready for review January 6, 2025 16:25
@BalduinLandolt BalduinLandolt merged commit 54033bd into main Jan 7, 2025
8 of 9 checks passed
@BalduinLandolt BalduinLandolt deleted the wip/minor-refactoring branch January 7, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants