is:wasm-ready tag #1336
Merged
is:wasm-ready tag #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Feb 8, 2024
jonasfj
approved these changes
Feb 8, 2024
isoos
reviewed
Feb 8, 2024
| @@ -20,11 +20,11 @@ Detected license: `MIT`. | |||
|
|
|||
| ## 20/20 Platform support | |||
|
|
|||
| ### [*] 20/20 points: Supports 4 of 6 possible platforms (**iOS**, **Android**, **Web**, Windows, **macOS**, Linux) | |||
There was a problem hiding this comment.
I think you need to rebase the PR on HEAD.
There was a problem hiding this comment.
Ah thanks! - I was getting very confused
isoos
approved these changes
Feb 8, 2024
kevmoo
previously requested changes
Feb 8, 2024
isoos
approved these changes
Feb 9, 2024
jonasfj
approved these changes
Feb 9, 2024
sigurdm
dismissed
kevmoo’s stale review
Landing now - we can always change stuff later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package will get the is:wasm-ready tag if it uses only the set of libraries
Only adds the is:wasm-ready tag, does not count it in scoring or mention in the report.
towards #1324