Skip to content

Commit

Permalink
Merge branch 'main' into datagen
Browse files Browse the repository at this point in the history
  • Loading branch information
mosuem authored Sep 13, 2024
2 parents 856fba0 + 863dc69 commit 14edcc9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/conformance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:

- name: Upload Reference Summary iff on main branch
if: github.ref == 'refs/heads/main'
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874
with:
name: reference_exec_summary
path: conformance/TEMP_DATA/testReports/exec_summary.json
2 changes: 1 addition & 1 deletion .github/workflows/intl4x_artifacts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
cp target/x86_64-pc-windows-msvc/release/icu4x-datagen.exe bin/windows_x64-datagen.exe
- name: Upload artifacts
uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874
with:
name: dart-${{matrix.os}}-${{ matrix.compiletype }}-libs
path: submodules/icu4x/bin
Expand Down
3 changes: 0 additions & 3 deletions pkgs/intl/lib/intl.dart
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,6 @@ class Intl {
return many ?? other;
case plural_rules.PluralCase.OTHER:
return other;
default:
throw ArgumentError.value(
howMany, 'howMany', 'Invalid plural argument');
}
}

Expand Down

0 comments on commit 14edcc9

Please sign in to comment.