Simplify ChainPiece. #1595
Merged
Simplify ChainPiece. #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were still passing in allowNewlines to _formatCall() even though that parameter was no longer used once Piece got the allowChildInState() API. So I removed that. Then I noticed that the switch in _formatCall() could be more cleanly handled by having the cases in format() calculate separate directly. So I did that. That left _formatCall() not actually doing anything useful, so I got rid of it. There are no behavioral change, it's just a code clean-up.
kallentu
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were still passing in
allowNewlinesto_formatCall()even though that parameter was no longer used once Piece got theallowChildInState()API. So I removed that.Then I noticed that the switch in
_formatCall()could be more cleanly handled by having the cases informat()calculateseparatedirectly. So I did that.That left
_formatCall()not actually doing anything useful, so I got rid of it.There are no behavioral change, it's just a code clean-up.