Format binary expressions with the new back-end. #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets the foundation in place for the new IR, the new visitor that produces it, the new line splitter that consumes it, the new style, and new tests for it. It also adds support for formatting library, import, and export directives to make sure everything is wired up together and working. Existing formatting behavior is unchanged. You have to opt in to the new stuff by passing "tall-style" as an experiment flag. This PR doesn't support comments, but it does leave some unused code in a few places that will be used to handle comments in future PRs. It has many UnimplementedError throws. Those will get filled in as more of the language is implemented in the new style. There are also two new kinds of TODO comments: TODO(tall): ... These comments describe that work that needs to be done before the new style is fully working. TODO(perf): ... These describe potential areas for optimization. Once more of the language is supported with the new IR and I can run some larger benchmark samples through it, I can start exploring where the actual performance problems are. For now, I'm just leaving breadcrumbs.
This also brings in InfixPiece which will be used for other infix operators and infix-like constructs.
This includes all arithmetic, logic, comparison, relational, type test, and bitwise operators. It doesn't include assignment operators, because those are right associative and need some special handling for how the RHS is indented.
# Conflicts: # example/format.dart # lib/src/back_end/code_writer.dart # lib/src/back_end/solution.dart # lib/src/back_end/solver.dart # lib/src/dart_formatter.dart # lib/src/front_end/ast_node_visitor.dart # lib/src/front_end/piece_factory.dart # lib/src/front_end/piece_writer.dart # lib/src/piece/import.dart # lib/src/piece/piece.dart # test/tall_format_test.dart # test/utils.dart
natebosch
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes all arithmetic, logic, comparison, relational, type test, and bitwise operators.
It doesn't include assignment operators, because those are right associative and need some special handling for how the RHS is indented.