Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to latest analyzer #3774

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Bump to latest analyzer #3774

merged 12 commits into from
Dec 16, 2024

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Dec 4, 2024

No description provided.

Copy link

github-actions bot commented Dec 4, 2024

PR Health

@kevmoo
Copy link
Member Author

kevmoo commented Dec 5, 2024

@jakemac53 – so adding the language bits break the community tests. Thoughts?

@jakemac53
Copy link
Contributor

@jakemac53 – so adding the language bits break the community tests. Thoughts?

This could happen if a builder factory string is configured using some syntax that isn't available in 3.6? cc @simolus3

@jakemac53
Copy link
Contributor

jakemac53 commented Dec 6, 2024

It does mean this is technically a breaking change unfortunately... if that is what is happening

@simolus3
Copy link
Contributor

simolus3 commented Dec 6, 2024

I'll take a look at the tests - but I think the build script should still run with an older language version due to the environment.sdk entry of the package where build_runner runs, right?

@kevmoo
Copy link
Member Author

kevmoo commented Dec 6, 2024

thanks!

@kevmoo kevmoo marked this pull request as ready for review December 6, 2024 22:36
@kevmoo
Copy link
Member Author

kevmoo commented Dec 12, 2024

Can we run w/ this @jakemac53 ?

@natebosch
Copy link
Member

I don't understand how this is breaking, I think the generated build script should be fine to hardcode to any language version.

Why do we need both the comment in the file and the argument to dart_style? Can we pick one or the other?

@kevmoo
Copy link
Member Author

kevmoo commented Dec 12, 2024

I don't understand how this is breaking, I think the generated build script should be fine to hardcode to any language version.

Why do we need both the comment in the file and the argument to dart_style? Can we pick one or the other?

@jakemac53 will have to comment. We have to put something into the dart_style ctor, obviously.

@jakemac53
Copy link
Contributor

@kevmoo once #3783 lands we should get this landed, happy to help with that. I think the merge conflicts will go away.

@jakemac53
Copy link
Contributor

We do need to update some changelogs though

@jakemac53
Copy link
Contributor

Skipping the changelog check for build_daemon, only dev_dependencies was touched

@jakemac53 jakemac53 merged commit 0c1e9db into master Dec 16, 2024
86 of 87 checks passed
@jakemac53 jakemac53 deleted the latest_analyzer branch December 16, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants