-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to latest analyzer #3774
Bump to latest analyzer #3774
Conversation
PR Health |
build_runner/lib/src/build_script_generate/build_script_generate.dart
Outdated
Show resolved
Hide resolved
@jakemac53 – so adding the language bits break the community tests. Thoughts? |
This could happen if a builder factory string is configured using some syntax that isn't available in 3.6? cc @simolus3 |
It does mean this is technically a breaking change unfortunately... if that is what is happening |
I'll take a look at the tests - |
build_runner/lib/src/build_script_generate/build_script_generate.dart
Outdated
Show resolved
Hide resolved
…te.dart Co-authored-by: Simon Binder <[email protected]>
thanks! |
Can we run w/ this @jakemac53 ? |
I don't understand how this is breaking, I think the generated build script should be fine to hardcode to any language version. Why do we need both the comment in the file and the argument to dart_style? Can we pick one or the other? |
@jakemac53 will have to comment. We have to put something into the dart_style ctor, obviously. |
We do need to update some changelogs though |
Skipping the changelog check for build_daemon, only dev_dependencies was touched |
No description provided.