Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 'dart compile js-dev' command for invoking DDC … #3768

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use the 'dart compile js-dev' command for invoking DDC … #3768

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2563965
Use the 'dart compile js-dev' command for invoking DDC instead of rea…
a-siva Oct 30, 2024
938f19c
Format.
a-siva Oct 30, 2024
9d4002d
Update version number.
a-siva Oct 31, 2024
dcd593d
remove build_modules from workspace, drop -z from upper bound
jakemac53 Oct 31, 2024
428d178
update versions/changelogs
jakemac53 Oct 31, 2024
de14b29
add dart_flutter_team_lints dependency to build_modules
jakemac53 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build_modules/lib/src/workers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ BazelWorkerDriver get _dartdevkDriver {
() => Process.start(
p.join(sdkDir, 'bin', 'dart'),
[
p.join(sdkDir, 'bin', 'snapshots', 'dartdevc.dart.snapshot'),
'compile',
'js-dev',
'--persistent_worker'
],
mode: _processMode,
Expand Down
2 changes: 1 addition & 1 deletion build_modules/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ repository: https://github.com/dart-lang/build/tree/master/build_modules
resolution: workspace

environment:
sdk: '>=3.5.0 <3.7.0-z'
sdk: '>=3.7.0-82.0.dev <3.8.0-z'
jakemac53 marked this conversation as resolved.
Show resolved Hide resolved
jakemac53 marked this conversation as resolved.
Show resolved Hide resolved

dependencies:
analyzer: '>=5.1.0 <7.0.0'
Expand Down
12 changes: 3 additions & 9 deletions build_web_compilers/lib/src/sdk_js_compile_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,11 @@ Future<void> _createDevCompilerModule(
try {
// Use standalone process instead of the worker due to
// https://github.com/dart-lang/sdk/issues/49441
var snapshotPath =
p.join(sdkDir, 'bin', 'snapshots', 'dartdevc_aot.dart.snapshot');
var execSuffix = Platform.isWindows ? '.exe' : '';
var dartPath = p.join(sdkDir, 'bin', 'dartaotruntime$execSuffix');
if (!File(snapshotPath).existsSync()) {
snapshotPath =
p.join(sdkDir, 'bin', 'snapshots', 'dartdevc.dart.snapshot');
dartPath = p.join(sdkDir, 'bin', 'dart$execSuffix');
}
var dartPath = p.join(sdkDir, 'bin', 'dart$execSuffix');
result = await Process.run(dartPath, [
snapshotPath,
'compile',
'js-dev',
'--multi-root-scheme=org-dartlang-sdk',
'--modules=amd',
if (canaryFeatures) '--canary',
Expand Down
2 changes: 1 addition & 1 deletion build_web_compilers/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ repository: https://github.com/dart-lang/build/tree/master/build_web_compilers
#resolution: workspace

environment:
sdk: '>=3.6.0-165.0.dev <3.7.0-z'
sdk: '>=3.7.0-82.0.dev <3.8.0-z'

dependencies:
analyzer: '>=5.1.0 <7.0.0'
Expand Down
Loading