Close windows via method call, minimize guis only if bot is running #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to fix targeted offer missclicks
do not insta-close settings gui repair hero via method call close guis only when bot is running
Punikekk
changed the title
Pablete1234
reviewed
Oct 29, 2023
Comment on lines
112
to
113
| if (!(minimizable && toggleVisibility()) && !(closable && close())) | ||
| legacyToggle(value); |
There was a problem hiding this comment.
Suggested change
| if (!(minimizable && toggleVisibility()) && !(closable && close())) | |
| legacyToggle(value); | |
| if (minimizable ? !toggleVisibility() : closeable ? !close() : false) { | |
| legacyToggle(value); | |
| } |
This logic is kinda confusing and hard to follow, what exactly is the intended flow?
if minimizable -> toggleVisibility (and fallback to legacyToggle)
if closeable -> close (and fallback to legacyToggle)
if neither? do nothing? or legacyToggle?
Shouldn't value be used within this method? (ie, what the end goal state is) such that visible ? toggleVisibility() : close() ?
Pablete1234
approved these changes
Nov 3, 2023
m9w
pushed a commit
to m9w/RealFreeDarkBot
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix targeted offer missclicks