Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework release leftovers gc algorithm #210

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

lburgazzoli
Copy link
Collaborator

@lburgazzoli lburgazzoli commented Aug 19, 2024

If the HelmInstance spec changes, all the resources get re-rendered which means some of them may become obsolete (i.e. if some resources are moved from cluster to namespace scope) hence a sort of "garbage collector task" must be executed.

As today, the GC logic would take into account only the resource generation, however, when the operator is updated, the geeneration won't change hence a new algorithm should be implemented to take into account also the release version.

Requires #209

@lburgazzoli lburgazzoli force-pushed the gc branch 6 times, most recently from 53e4877 to b98550a Compare August 19, 2024 15:25
If the HelmInstance spec changes, all the resources get re-rendered which means some of
them may become obsolete (i.e. if some resources are moved from cluster to namespace
scope) hence a sort of "garbage collector task" must be executed.

As today, the GC logic would take into account only the resource generation, however,
when the operator is updated, the generation won't change hence a new algorithm should
be implemented to take into account also the release version.

Signed-off-by: Luca Burgazzoli <[email protected]>
@lburgazzoli lburgazzoli marked this pull request as ready for review August 20, 2024 06:27
@lburgazzoli lburgazzoli merged commit d460da3 into dapr:main Aug 27, 2024
12 checks passed
@lburgazzoli lburgazzoli deleted the gc branch August 27, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant