feat: Adding basic HTTPEndpoint configuration support in testcontainers module #1210
+112
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs module Signed-off-by: Laurent Broudoux <[email protected]>
Signed-off-by: Laurent Broudoux <[email protected]>
|
Hey there! I don't see where to put the documentation at the moment... Is there a specific |
|
@lbroudoux thanks so much for this contribution! |
|
@artur-ciocanu @artursouza @cicoyle please review! this looks awesome to me! |
|
@lbroudoux good to see you again! And thanks for your contributions! I will ask around to make sure your PR is reviewed and merged. |
|
Glad to see you again as well @artur-ciocanu! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the #1209 proposal issue.
Description
HttpEndpointandHttpEndpointYamlConverteras done before for Subscriptions and Components,withHttpEndpoint(HttpEndpoint endpoint)method onDaprContainerWhen
HTTPEndpointsare registered, the test containers module creates Yaml files within the/dapr-resourcesfolder, which is mounted into the sidecar container.Issue reference
See #1209
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: