Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved technical details of Jobs implementation out of How To docs #4500

Merged
merged 16 commits into from
Feb 3, 2025

Conversation

WhitWaldo
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

The How-To docs typically are expected to contain SDK-specific implementation examples, but in the case of Jobs, the Go codetab contains a lot of technical detail that's extraneous to implementing the example given. This PR pulls those details out into a separate page.

I also scoured all the responses to queries about Jobs from Discord since the Jobs channel was created and included notes about those answers so they're more publicly accessible.

Issue reference

Please reference the issue this PR will close: #4498

… To page and into a separate one

Signed-off-by: Whit Waldo <[email protected]>
@WhitWaldo WhitWaldo requested review from a team as code owners January 22, 2025 13:47
@hhunter-ms hhunter-ms added this to the 1.15 milestone Jan 22, 2025
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for starting this!

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick 2nd review

WhitWaldo and others added 2 commits January 23, 2025 18:10
…bs/jobs-features-concepts.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…bs/jobs-features-concepts.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Copy link

Stale PR, paging all reviewers

@hhunter-ms hhunter-ms merged commit ad285bc into dapr:v1.15 Feb 3, 2025
4 checks passed
@WhitWaldo WhitWaldo deleted the jobs-reorg branch February 3, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants