-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved technical details of Jobs implementation out of How To docs #4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… To page and into a separate one Signed-off-by: Whit Waldo <[email protected]>
hhunter-ms
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for starting this!
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
…bs/jobs-features-concepts.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
…bs/jobs-features-concepts.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
…bs/jobs-features-concepts.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
hhunter-ms
requested changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick 2nd review
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
…bs/jobs-features-concepts.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
…bs/jobs-features-concepts.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Whit Waldo <[email protected]>
Stale PR, paging all reviewers |
Signed-off-by: Whit Waldo <[email protected]>
hhunter-ms
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
The How-To docs typically are expected to contain SDK-specific implementation examples, but in the case of Jobs, the Go codetab contains a lot of technical detail that's extraneous to implementing the example given. This PR pulls those details out into a separate page.
I also scoured all the responses to queries about Jobs from Discord since the Jobs channel was created and included notes about those answers so they're more publicly accessible.
Issue reference
Please reference the issue this PR will close: #4498