Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes subscribeType metadata field not being respected for Pulsar pub sub #3603

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Nov 15, 2024

  • Fixes subscribeType metadata field not being respected
  • Fixes bug not allowing to connect to remote endpoints starting with pulsar:// or pulsar+ssl://

We have the subscribeType field documented, but the existing code implementation suggested we'd be reading that value off of the subscription metadata:

var defaultSubscription = &common.Subscription{
		PubsubName: pubsubName,
		Topic:      topicName,
		Route:      "/orders",
		Metadata:   map[string]string{"subscribeType": "key_shared"},
	}

Should we use what's set in the component file as default and override with the subscription metadata?

Issue reference

#3601

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

…t to remote endpoints starting with `pulsar://` or `pulsar+ssl://`

Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska requested review from a team as code owners November 15, 2024 02:32
@elena-kolevska elena-kolevska changed the title Fixes subscription type not being parsed for Pulsar pub sub Fixes subscribeType metadata field not being respected for Pulsar pub sub Nov 15, 2024
@elena-kolevska elena-kolevska marked this pull request as draft November 15, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant