Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont distribute to validators not in status "activeOngoing" #226

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Dont distribute to validators not in status "activeOngoing" #226

merged 10 commits into from
Oct 10, 2024

Conversation

Marketen
Copy link
Contributor

@Marketen Marketen commented Sep 17, 2024 •
edited by alrevuelta
Loading

Closes #227

  • Every given interval, slashed and exited validators subscribed to the pool are unsubscribed, splitting their pending rewards to the rest of the validators.

alrevuelta
alrevuelta requested changes Sep 23, 2024
View reviewed changes
oracle/oracle.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
oracle/onchain.go Outdated Show resolved Hide resolved
oracle/oracle.go Show resolved Hide resolved
alrevuelta
alrevuelta reviewed Sep 23, 2024
View reviewed changes
oracle/oracle.go Outdated Show resolved Hide resolved
@Marketen Marketen mentioned this pull request Sep 25, 2024
Closed
alrevuelta
alrevuelta reviewed Oct 6, 2024
View reviewed changes
oracle/onchain.go Outdated Show resolved Hide resolved
oracle/oracle.go Outdated Show resolved Hide resolved
alrevuelta
alrevuelta reviewed Oct 7, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
alrevuelta
alrevuelta reviewed Oct 7, 2024
View reviewed changes
oracle/onchain.go Show resolved Hide resolved
oracle/onchain.go Outdated Show resolved Hide resolved
oracle/oracle.go Outdated Show resolved Hide resolved
oracle/oracle.go Outdated Show resolved Hide resolved
oracle/types.go Outdated Show resolved Hide resolved
alrevuelta
alrevuelta reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit tests and we are good to go.

Marketen
Marketen commented Oct 10, 2024
View reviewed changes
Copy link
Contributor Author

@Marketen Marketen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alrevuelta
alrevuelta approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@alrevuelta alrevuelta merged commit 87d7b98 into main Oct 10, 2024
4 checks passed
@alrevuelta alrevuelta deleted the marc/rewards-distribution-fix branch October 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alrevuelta alrevuelta alrevuelta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exiting validators without unsubscribing does not remove them from the pool
2 participants
@Marketen @alrevuelta