new API endpoint: blocks x validator #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marketen
force-pushed
the
api_add_blockXval
branch
3 times, most recently
from
506fc95
to
83a9825
Compare
Marketen
force-pushed
the
api_add_blockXval
branch
from
83a9825
to
d3eaade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API endpoint that returns all blocks proposed, missed or with wrong fee of each validator (defined by validator index). The return is a JSON array of the following object, ordered by validatorIndex:
Important: Even though the JSON array is ordered by validatorIndex, the arrays of blocks of each validator are not ordered in this endpoint, since I suppose that the slice of the state that holds the blocks is already ordered by default (since they are appended one by one in each incrementing slot)
Alongside the new API endpoint, a new unit test for the endpoint is also added. The unit test can still be improved. At the time of writing, it mocks a oracle state with 300 blocks different types and +50 different validators so that the endpoint can be tested