Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generic multi-call scheme - 2.0 #2187

Closed
wants to merge 8 commits into from
Closed

Support generic multi-call scheme - 2.0 #2187

wants to merge 8 commits into from

Conversation

roienatan
Copy link
Contributor

@roienatan roienatan commented Oct 13, 2020 •
edited
Loading

resolves: #2186

Also:

  • Update the single call generic scheme to be consistent with the multi-call (removed SelectSearch component)
  • Use same validation code to reduce duplicated code
  • Fix issue that user data is not saved when you close the proposal modal and go back.
  • More minor code improvements

@orenyodfat orenyodfat temporarily deployed to alchemy-generic-multi-c-9b1yse October 14, 2020 15:54 Inactive
@roienatan
Improvments to single call generic scheme ; Removed SelectSearch comp…
4342ba6 
…onent ; Minor changes to multi-call generic scheme
@roienatan roienatan temporarily deployed to alchemy-generic-multi-c-9b1yse October 15, 2020 13:31 Inactive
@roienatan roienatan changed the title Support multi-call generic scheme Support generic multi-call scheme - 2.0 Oct 16, 2020
@roienatan roienatan temporarily deployed to alchemy-generic-multi-c-9b1yse October 18, 2020 08:20 Inactive
@orenyodfat
Copy link
Contributor

duplicate at daostack/alchemy_2#4

@orenyodfat orenyodfat closed this Nov 4, 2020
@roienatan roienatan deleted the generic-multi-call-scheme branch November 7, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkent600 dkent600 Awaiting requested review from dkent600

@orenyodfat orenyodfat Awaiting requested review from orenyodfat

Assignees
No one assigned
Labels
2.0 Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roienatan @orenyodfat