Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new package fwfh_math #471

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

daohoangson
Copy link
Owner

@daohoangson daohoangson commented Mar 14, 2021

Related to #177

TODO

@daohoangson daohoangson temporarily deployed to vercel March 14, 2021 16:30 Inactive
@daohoangson
Copy link
Owner Author

On Simulator:

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #471 (3c5e34f) into master (40b7e56) will decrease coverage by 1.51%.
The diff coverage is n/a.

❗ Current head 3c5e34f differs from pull request most recent head 87c4806. Consider uploading reports for the commit 87c4806 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   98.30%   96.78%   -1.52%     
==========================================
  Files          54       45       -9     
  Lines        3358     2798     -560     
==========================================
- Hits         3301     2708     -593     
- Misses         57       90      +33     
Impacted Files Coverage Δ
...fwfh_chewie/lib/src/video_player/video_player.dart 82.97% <0.00%> (-17.03%) ⬇️
packages/core/lib/src/widgets/html_table.dart 90.43% <0.00%> (-8.80%) ⬇️
packages/core/lib/src/widgets/html_ruby.dart 91.37% <0.00%> (-5.40%) ⬇️
packages/core/lib/src/internal/ops/tag_li.dart 94.89% <0.00%> (-5.11%) ⬇️
packages/core/lib/src/internal/ops/column.dart 96.42% <0.00%> (-3.58%) ⬇️
...ackages/fwfh_webview/lib/src/web_view_factory.dart 88.23% <0.00%> (-1.24%) ⬇️
packages/core/lib/src/internal/ops/tag_ruby.dart 95.55% <0.00%> (-0.19%) ⬇️
packages/core/lib/src/widgets/css_sizing.dart 94.40% <0.00%> (-0.18%) ⬇️
packages/core/lib/src/core_widget_factory.dart 99.53% <0.00%> (-0.07%) ⬇️
packages/core/lib/src/data/css.dart 100.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7e56...87c4806. Read the comment docs.

@daohoangson
Copy link
Owner Author

On CanvasKit (html renderer doesn't seem to work):

Screen Shot 2021-03-14 at 23 36 43

@Skyost
Copy link

Skyost commented Mar 15, 2021

As I said in #177 (comment), I've worked on my own implementation of flutter_math_fork in flutter_widget_from_html. I had (and I'm still having) a lot of troubles with overflows and line breaks, does it fully works for you ?

@daohoangson
Copy link
Owner Author

The current state of the flutter_math package and its fork is not ideal, so this is mostly a proof of concept which shows the power of the modularization project.

There are issues with the vertical alignment and as you said, line breaks. Let me know if you have trouble with specific HTML / equation.

@Skyost
Copy link

Skyost commented Mar 16, 2021

There are issues with the vertical alignment and as you said, line breaks.

I recently had some success with vertical alignement and line breaks (see implementation : znjameswu/flutter_math#29 (comment)). It's not perfect, but it's working as expected.

Let me know if you have trouble with specific HTML / equation.

Not in particular, I was just curious about this pull request 😊

@daohoangson daohoangson added this to the 0.8.0 milestone Jun 13, 2021
@daohoangson daohoangson removed this from the 0.9.0 milestone Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants