Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add basic support for text-transform #1162

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ngthailam
Copy link
Contributor

@ngthailam ngthailam commented Jan 15, 2024

Add support for text-transformation for #642

Changes:

  • Add code for basic text-transformation: capitalize, uppercase, lowercase, none
  • Add related UTs

Notes:

I am doing the basic implementation first, so these features are not supported yet.

  • Have NOT check support for multi language.
  • Have NOT support other text-transformation(s) yet.

@ngthailam ngthailam marked this pull request as draft January 15, 2024 15:47
@ngthailam ngthailam changed the title WIP: Add support text-transform WIP: Add basic support for text-transform Jan 15, 2024
@ngthailam
Copy link
Contributor Author

ngthailam commented Jan 15, 2024

@daohoangson Can you provide me with some guidance on this, I am having some trouble:

  • p, center, h123456 tags works with text-transform
  • However some tags like abbr or blockquote, the CssTextTransform cannot be found in the InheritedProperties. These tags works with text-transform on the Web.

I m trying to debug the root cause but it is quite complicated as I dont know the system well.
Would you have an idea on this ?

@daohoangson
Copy link
Owner

Text transform may be complicated than this. It must work across different tags, e.g. <p style="text-transform: capitalize">h<em>el</em>lo w<strong>orl</strong>d</p>...

@ngthailam
Copy link
Contributor Author

Let me look more into this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants