treewide: use lib.singleton #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces indent depth, recommended by [rfc 0166](https://github.com/NixOS/rfcs/blob/master/rfcs/0166-nix-formatting.md#singleton-lists)
|
I don't got add label perms, could someone add backport release-24.11 |
trueNAHO
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks a lot for making this change!
However, it might be safe to say that most Nix users are (sadly) not very experienced with the available pkgs and lib functionality. I suggest not using lib.singleton in the /docs/ documentation to reduce potential confusion.
Merged
trueNAHO
approved these changes
Jan 8, 2025
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-754-to-release-24.11 origin/release-24.11
cd .worktree/backport-754-to-release-24.11
git switch --create backport-754-to-release-24.11
git cherry-pick -x 6d9867604efd73274bbe40fe974af66e9e3faa04 |
|
erm could someone backport this to 24.11 for me? |
awwpotato
added a commit
to awwpotato/stylix
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduces indent depth, recommended by rfc 0166