Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fctix5: init #718

Merged
merged 8 commits into from
Jan 1, 2025
Merged

fctix5: init #718

merged 8 commits into from
Jan 1, 2025

Conversation

make-42
Copy link
Contributor

@make-42 make-42 commented Jan 1, 2025

fcitx5: init

@vetbercy
fctix5: init
e66a330 
fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init

fcitx5: init
@vetbercy
fcitx5: init
270dcfc
trueNAHO
trueNAHO requested changes Jan 1, 2025
View reviewed changes
modules/fcitx5/theme.conf.mustache Outdated Show resolved Hide resolved
modules/fcitx5/hm.nix Outdated Show resolved Hide resolved
modules/fcitx5/hm.nix Outdated Show resolved Hide resolved
modules/fcitx5/hm.nix Outdated Show resolved Hide resolved
make-42 and others added 4 commits January 1, 2025 21:26
@make-42 @trueNAHO
fctix5: init
de75687 
Co-authored-by: NAHO <[email protected]>
@make-42 @trueNAHO
fctix5: init
cb289f6 
Co-authored-by: NAHO <[email protected]>
@make-42 @trueNAHO
fctix5: init
ecff839 
Co-authored-by: NAHO <[email protected]>
@make-42 @trueNAHO
fctix5: init
f05a10f 
Co-authored-by: NAHO <[email protected]>
@make-42
Copy link
Contributor Author

make-42 commented Jan 1, 2025 •
edited
Loading

All requested changes were applied, thank you!

trueNAHO
trueNAHO requested changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding comments to each of the three template files, where you got them from.

modules/fcitx5/hm.nix Outdated Show resolved Hide resolved
@make-42 @trueNAHO
fctix5: init
0e71879 
Co-authored-by: NAHO <[email protected]>
@make-42
Copy link
Contributor Author

make-42 commented Jan 1, 2025

Consider adding comments to each of the three template files, where you got them from.

Sure will do!

trueNAHO
trueNAHO approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that it is currently not easily possible to extend Mustache files in Stylix, I am fine with modules/fcitx5/theme.conf.mustache containing subjective settings.

In the future, this will be resolved upon closing #704, which is part of #534.

@make-42
Copy link
Contributor Author

make-42 commented Jan 1, 2025

Alright!

@trueNAHO trueNAHO merged commit 911c07f into danth:master Jan 1, 2025
12 checks passed
@make-42 make-42 mentioned this pull request Jan 3, 2025
Open
stylix-automation bot pushed a commit that referenced this pull request Jan 4, 2025
@make-42 @github-actions
fctix5: init (#718)
d0701cc 
Link: #718

Reviewed-by: NAHO <[email protected]>
(cherry picked from commit 911c07f)
@stylix-automation
Copy link

Successfully created backport PR for release-24.11:

@stylix-automation stylix-automation bot mentioned this pull request Jan 4, 2025
Merged
trueNAHO pushed a commit that referenced this pull request Jan 4, 2025
@make-42 @trueNAHO
fctix5: init (#718)
9c76731 
Link: #718

Reviewed-by: NAHO <[email protected]>
(cherry picked from commit 911c07f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueNAHO trueNAHO trueNAHO approved these changes

Assignees
No one assigned
Labels
backport release-24.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@make-42 @trueNAHO @vetbercy