Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🖌️ fix: ordered lists markers #4568

Merged
merged 4 commits into from
Oct 28, 2024
Merged

🖌️ fix: ordered lists markers #4568

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce24c5a
fix ordered lists markers styling
thingersoft Oct 25, 2024
d30eebf
cleanup
thingersoft Oct 25, 2024
9ce6287
refactor: additional padding for 3-digit markers
danny-avila Oct 28, 2024
ab997c5
Refactor CSS to remove extra spacing in lists
danny-avila Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 1 addition & 56 deletions client/src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,7 +2006,7 @@ button.scroll-convo {
list-style-position: outside;
margin-top: 1em;
margin-bottom: 1em;
padding-left: 1.625em;
padding-left: 3em;
}

.prose li,
Expand All @@ -2019,19 +2019,16 @@ button.scroll-convo {
.prose ol,
.markdown ol {
list-style-type: decimal;
counter-reset: list-counter;
}

.prose ol > li,
.markdown ol > li {
position: relative;
padding-left: 0.375em;
counter-increment: list-counter;
}

.prose ol > li::marker,
.markdown ol > li::marker {
content: counter(list-counter) '. ';
color: var(--tw-prose-counters);
font-weight: 400;
}
Expand All @@ -2040,33 +2037,11 @@ button.scroll-convo {
.prose ol ol,
.markdown ol ol {
list-style-type: lower-alpha;
counter-reset: list-counter-alpha;
}

.prose ol ol > li,
.markdown ol ol > li {
counter-increment: list-counter-alpha;
}

.prose ol ol > li::marker,
.markdown ol ol > li::marker {
content: counter(list-counter-alpha, lower-alpha) '. ';
}

.prose ol ol ol,
.markdown ol ol ol {
list-style-type: lower-roman;
counter-reset: list-counter-roman;
}

.prose ol ol ol > li,
.markdown ol ol ol > li {
counter-increment: list-counter-roman;
}

.prose ol ol ol > li::marker,
.markdown ol ol ol > li::marker {
content: counter(list-counter-roman, lower-roman) '. ';
}

/* Unordered lists */
Expand Down Expand Up @@ -2109,14 +2084,6 @@ button.scroll-convo {
margin-bottom: 0.75em;
}

/* Remove extra spacing */
.prose > ul > li > *:first-child,
.prose > ol > li > *:first-child,
.markdown > ul > li > *:first-child,
.markdown > ol > li > *:first-child {
margin-top: 1.25em;
}

.prose > ul > li > *:last-child,
.prose > ol > li > *:last-child,
.markdown > ul > li > *:last-child,
Expand All @@ -2130,28 +2097,6 @@ button.scroll-convo {
color: currentColor;
}

/* Reset counter for new sections */
.prose h1 + ol,
.prose h2 + ol,
.prose h3 + ol,
.prose h4 + ol,
.prose h5 + ol,
.prose h6 + ol,
.markdown h1 + ol,
.markdown h2 + ol,
.markdown h3 + ol,
.markdown h4 + ol,
.markdown h5 + ol,
.markdown h6 + ol {
counter-reset: list-counter;
}

/* Reset counter after unordered lists */
.prose ul + ol,
.markdown ul + ol {
counter-reset: list-counter;
}

/* Keyframes */

@keyframes slideFromLeftToRightAndFade {
Expand Down