-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rdb multiple args #140
base: master
Are you sure you want to change the base?
Rdb multiple args #140
Conversation
Adding multiple argument support for rAnd, rOr, and contains
Cool, thanks for the pull request @Geekimo . I'll see to get this into the next version. A bit of background: So far I've restrained from introducing variadic functions into PHP-ReQL, for the reason that it creates ambiguities whenever a ReQL term accepts optional arguments. Since optional (named) arguments in PHP-ReQL are just passed in as an object, we have to be able to distinguish whether a given argument is a set of options, or just an object that should be converted to a ReQL datum. If all functions have a fixed number of arguments, this is easy, since the optional argument object has a fixed position too (always the last argument). With variadic functions this no longer works, and things get hacky and potentially ambiguous. For the particular cases of |
Adding php-rql multiple (>2) arguments support for the following API functions:
Plus a few enhancements for PSR-2 support.