add support for searching for CAPI clusters in the current context #154
Conversation
eljohnson92
force-pushed
the
enhance-capi-support
branch
from
a7f55b0 to
aff97d0
Compare
There was a problem hiding this comment.
I like the idea of optionally searching for CAPI clusters in the current context. So you could just switch to the management cluster using kubeswitch to then discover the CAPI clusters there (instead of defining a store per management cluster if that does not fit your workflow)
| } | ||
| return | ||
| } | ||
| s.Logger.Debug("CAPI: cannot listing v1beta1.Cluster resources, not currently connected to a cluster with CAPI installed") |
There was a problem hiding this comment.
It probably would be good to check the error string to if it indicates missing Cluster CRD. Or directly probe the K8s API for the Cluster CRD.
There was a problem hiding this comment.
great idea, playing around with some ways to do that now, I'll have an update shortly
There was a problem hiding this comment.
This should now be fixed to return an error if there is an error other than the CRD not being found
This PR allows you to passively search any cluster in your current context for CAPI clusters if a kubeconfigPath is not defined. This makes this store more flexible as mgmt clusters are deleted, created, and switched between. Open to any feedback on any explanations or implementations here. an alternative to this is we could add an explicit
useCurrentContext: truebool or something like that