Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analogReference Functionality #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Merrr
Copy link

@Merrr Merrr commented May 7, 2014

Full functionality for analogReference:

  • DEFAULT: Use VCC as ref
  • INTERNAL/INTERNAL1V1: Use internal 1v1 as ref
  • INTERNAL2V56: Use internal 2v56 as ref
  • EXTERNAL: Use external ref (not tested!)

Full functionality for analogReference:
- DEFAULT: Use VCC as ref
- INTERNAL/INTERNAL1V1: Use internal 1v1 as ref
- INTERNAL2V56: Use internal 2v56 as ref
- EXTERNAL: Use external ref (not tested!)
@damellis
Copy link
Owner

Adding analogReference() support would be great (if it doesn't work right now). But this patch looks like it's against the old "pre1" ATtiny files that included their own version of the Arduino core. The current ATtiny support (in master for 1.0.x and ide-1.5.x) relies on the standard core file in the Arduino distribution. Do you want to look into supporting analogReference() for those branches (i.e. using the standard Arduino core)?

@mischnic
Copy link

It seems like it isn't possible putting modified Arduino.h and wiring_analog.c files somewhere to override the ones supplied by Arduino.
Would it be okay to create a whole new core for this?

@damellis
Copy link
Owner

I don't think this is worth including a whole new core for. I think it's important to avoid doing that because it gets out of sync with the main Arduino core and it's easy to fall behind on changes / bug fixes. If there are things that need to be changed in the core, we should try to get the Arduino repository updated. Do you want to open a pull request there?

@mischnic
Copy link

Here's the pull request: arduino/Arduino#5300

@mischnic
Copy link

mischnic commented Sep 8, 2016

The pull request just got merged, the fix will be in Arduino 1.6.12 .
@damellis This pull request can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants