Hba records simplification #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 97.60% 97.58% -0.02%
==========================================
Files 10 10
Lines 1211 1201 -10
==========================================
- Hits 1182 1172 -10
Misses 29 29 ☔ View full report in Codecov by Sentry. |
dlax
requested changes
Dec 6, 2024
pgiraud
force-pushed
the
hba_records_simplification
branch
from
3246453 to
350c898
Compare
dlax
requested changes
Dec 6, 2024
pgiraud
force-pushed
the
hba_records_simplification
branch
from
350c898 to
fc5fbac
Compare
We follow the names used by postgresql (https://www.postgresql.org/docs/current/auth-pg-hba-conf.html). `databases` and `users` are accessible via properties though.
The values argument wasn't really useful. It also makes Mypy happy with the following syntax: HBARecord(**a_mapping) The previous required syntax was: HBARecord(values=a_mapping)
pgiraud
force-pushed
the
hba_records_simplification
branch
from
fc5fbac to
998f2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.