Fix broken upload to Codecov #142
Merged
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we get a comment posted by codecov with the result? |
There's one. Even if it doesn't seem relevant for the current PR. https://github.com/dalibo/pgtoolkit/actions/runs/11911363886/job/33192697186#step:6:51 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 97.48% 97.53% +0.04%
==========================================
Files 10 10
Lines 1191 1215 +24
==========================================
+ Hits 1161 1185 +24
Misses 30 30 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Oh, apparently I didn't provide the correct token in project settings. Fixed. |
dlax
approved these changes
Nov 19, 2024
Codecov now requires a TOKEN to upload results. We update the version of the github action and use the token added in the project settings. We write the coverage report as XML in a file for codecov upload to be happy. With the default .coverage file, codecov reports a "no coverage file found" error.
pgiraud
force-pushed
the
codecov_update
branch
from
5aa10db to
2db8fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov now requires a TOKEN to upload results.
We update the version of the github action and use the token added in the project settings.
We write the coverage report as XML in a file for codecov upload to be happy. With the default .coverage file, codecov reports a "no coverage file found" error.
Fixes #140