Fix connection service serialization wrongly including 'name' parameter #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 97.47% 97.48%
=======================================
Files 10 10
Lines 1190 1191 +1
=======================================
+ Hits 1160 1161 +1
Misses 30 30 ☔ View full report in Codecov by Sentry. |
The Service class overwrite __setattr__ to invoke __setitem__ so the statement 'self.name = name' in Service.__init__() will actually add the 'name' key to the Service (which is a dict). Then, as serialization invokes .items() to get service parameters, the 'name' field is written whereas is should not. We invoke __setattr__() from super() in order to avoid that and also declare the 'name' attribute in the class in order to keep type checking working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #118