Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Rows removed by index recheck" from Misc to general table #695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move "Rows removed by index recheck" from Misc to general table #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/components/PlanNodeDetail.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,27 @@ watch(activeTab, () => {
v-tippy="{ allowHTML: true, content: filterDetailTooltip }"
></FontAwesomeIcon>
</div>

<div v-if="node[NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK]">
<FontAwesomeIcon
fixed-width
:icon="faFilter"
class="text-secondary"
></FontAwesomeIcon>
<b> {{ NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK }}: </b>
<span class="px-1">{{
tilde + formattedProp("ROWS_REMOVED_BY_INDEX_RECHECK")
}}</span>
<FontAwesomeIcon
fixed-width
:icon="faInfoCircle"
class="text-muted"
v-tippy="{
content: `Not enough memory, try increasing work_mem`,
}"
></FontAwesomeIcon>
</div>

<div v-if="node[NodeProp.HEAP_FETCHES]">
<FontAwesomeIcon
fixed-width
Expand Down
2 changes: 2 additions & 0 deletions src/enums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export enum NodeProp {
PLAN_WIDTH = "Plan Width",
ROWS_REMOVED_BY_FILTER = "Rows Removed by Filter",
ROWS_REMOVED_BY_JOIN_FILTER = "Rows Removed by Join Filter",
ROWS_REMOVED_BY_INDEX_RECHECK = "Rows Removed by Index Recheck",
ACTUAL_STARTUP_TIME = "Actual Startup Time",
ACTUAL_TOTAL_TIME = "Actual Total Time",
ACTUAL_LOOPS = "Actual Loops",
Expand Down Expand Up @@ -174,6 +175,7 @@ nodePropTypes[NodeProp.ROWS_REMOVED_BY_FILTER] = PropType.rows
nodePropTypes[NodeProp.ROWS_REMOVED_BY_JOIN_FILTER] = PropType.rows
nodePropTypes[NodeProp.ROWS_REMOVED_BY_FILTER_REVISED] = PropType.rows
nodePropTypes[NodeProp.ROWS_REMOVED_BY_JOIN_FILTER_REVISED] = PropType.rows
nodePropTypes[NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK] = PropType.rows
nodePropTypes[NodeProp.HEAP_FETCHES] = PropType.rows
nodePropTypes[NodeProp.OUTPUT] = PropType.list
nodePropTypes[NodeProp.SORT_KEY] = PropType.list
Expand Down
1 change: 1 addition & 0 deletions src/services/help-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ const notMiscProperties: string[] = [
NodeProp.NODE_ID,
NodeProp.ROWS_REMOVED_BY_FILTER,
NodeProp.ROWS_REMOVED_BY_JOIN_FILTER,
NodeProp.ROWS_REMOVED_BY_INDEX_RECHECK,
NodeProp.ACTUAL_ROWS_REVISED,
NodeProp.PLAN_ROWS_REVISED,
NodeProp.ROWS_REMOVED_BY_FILTER_REVISED,
Expand Down
Loading