Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping ed25519 to =1.3.0 #217

Closed
wants to merge 1 commit into from
Closed

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Oct 15, 2022

as suggested by @tarcieri #205 (comment)

The current MSRV test is failing because the ed25519 crate is Rust 2021 edition.
The easiest way to work around that is probably to check in Cargo.lock and ensure it's computed for ed25519 v1.3.0, possibly by adding a temporary =1.3.0 version requirement when computing Cargo.lock.

@rozbb
Copy link
Contributor

rozbb commented Oct 15, 2022

Switching to v1.2.0 fixes the build. @tarcieri can you explain the plan for this change? Is the MSRV broken in the current release, and was this intended to fix it, or is the next release going to have the same MSRV?

@tarcieri
Copy link
Contributor

@rozbb I’d suggest bumping MSRV to 1.56 in the next release.

Since you just merged a breaking change (#205), maybe that should just happen now.

@rozbb
Copy link
Contributor

rozbb commented Oct 15, 2022 via email

@tarcieri
Copy link
Contributor

If MSRV is bumped, then yeah

@rozbb
Copy link
Contributor

rozbb commented Oct 16, 2022

Closing in favor of discussion in #218

@rozbb rozbb closed this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants