ed25519-dalek: hide secret in SigningKey's Debug impl
#592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
ed25519-dalek/better-signingkey-debug-impl
branch
from
6ab3b34
to
53308d2
Compare
|
Oh joy, we're getting hit by an unrelated nightly regression that misidentifies unused imports. Let me open a separate PR for that. Edit: opened #593 |
robjtede
approved these changes
Oct 31, 2023
Uses `finish_non_exhaustive` in lieu of printing the `secret_key` component of a `SigningKey`, only showing the corresponding `verifying_key` field which can be used to identify the public key. Closes #591
tarcieri
force-pushed
the
ed25519-dalek/better-signingkey-debug-impl
branch
from
53308d2
to
e799c74
Compare
|
Rebased. Hopefully that fixes the build. |
rozbb
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
finish_non_exhaustivein lieu of printing thesecret_keycomponent of aSigningKey, only showing the correspondingverifying_keyfield which can be used to identify the public key.Closes #591