Tesla bugfixes #818
Open
Tesla bugfixes #818
+25
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug updated to display accurate data including PCS temps in more battery info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bugs noted in Tesla to fix:
More Battery Info 0x352 displaying non mux data when it should display mux.
PCS temperatures not accurate in More Battery Info.
DEBUG data not displaying 0x2B4 HV, LV data accurately.
Why
@josiahhiggs was here
How
Added BMS352_mux = true
Revised bitwise for PCS
Revised 0x2B4 data display in DEBUG
151.000 ERROR: BMS_a035_SW_Isolation
151.000 ERROR: BMS_a036_SW_HvpHvilFault
151.000 STATUS: Contactor: CLOSED, HVIL: STATUS_OK, NegativeState: ECONOMIZED, PositiveState: ECONOMIZED, setState:
OPENING, close allowed: Yes, Pyrotest: No
151.000 Battery values: Real SOC: 90.3, Battery voltage: 353V, Battery HV current: 0A, Fully charged?: YES, LFP chemistry detected!
151.000 Cellstats, Max: 3328mV (cell 13), Min: 3324mV (cell 16), Imbalance: 4mV.
151.000 High Voltage Output Pins: 352.59 V, Low Voltage: 14.18 V, DC/DC 12V current: 4.50 A.
151.000 PCS_ambientTemp: 47.70°C, DCDC_Temp: 59.30°C, ChgPhA: 46.70°C, ChgPhB: 46.70°C, ChgPhC: 46.40°C
151.000 Values passed to the inverter:
151.000 SOC: 90.30%
151.001 Max discharge power: 60000W, Max charge power: 14550W
151.001 Max temperature: 25°C, Min temperature: 29°C